Closed Cobinja closed 5 years ago
hey @Cobinja this patch doesn't apply due to mismatched line numbers; you'll need to ensure it applies locally with script/update
. We can get this merged once that's fixed up!
@codebytere I forced-pushed a new version. It wasn't the line numbers you suspected. I can't tell what it actually was but I suspect a confusion of line-ending types
Description of Change
Backport libcc portion of https://github.com/electron/electron/pull/15878 to
3-0-x
/cc @inukshukChecklist
.patches.yaml
script/update
runs without errorNotes
srcipt/update
runs into the (probably) same error as in https://github.com/electron/libchromiumcontent/pull/690#issuecomment-424504022 The patch file actually gets applied, but the script tells otherwise