electron / libchromiumcontent

Shared library build of Chromium’s Content module
MIT License
485 stars 183 forks source link

fix: expose libgtkui::GetFgColor (backport: 3-1-x) #742

Closed Cobinja closed 5 years ago

Cobinja commented 5 years ago
Description of Change

Backport libcc portion of https://github.com/electron/electron/pull/15878 to 3-1-x /cc @inukshuk

Checklist
Notes

srcipt/updateruns into the (probably) same error as in https://github.com/electron/libchromiumcontent/pull/690#issuecomment-424504022 The patch file actually gets applied, but the script tells otherwise

codebytere commented 5 years ago

hey @Cobinja this patch doesn't apply due to mismatched line numbers; you'll need to ensure it applies locally with script/update. We can get this merged once that's fixed up!

Cobinja commented 5 years ago

@codebytere I forced-pushed a new version. It wasn't the line numbers you suspected. I can't tell what it actually was but I suspect a confusion of line-ending types