disable_clang still valid?

electron / libchromiumcontent

Shared library build of Chromium’s Content module

MIT License

485 stars 183 forks source link

disable_clang still valid? #744

Closed Thaodan closed 5 years ago

Thaodan commented 5 years ago

Where did disable_clang from https://github.com/electron/electron/pull/5377/commits/26e4ce30bbcc05290f4ffbd320823414408f9d7a go? I want to pass it before building electron.

nornagon commented 5 years ago

libchromiumcontent is legacy code and only used to build Electron 2 and 3. Additionally, we don't support building without clang. I'm afraid you're on your own here!

Thaodan commented 5 years ago

Ah so after 3.x its not needed to pass the option? Its very said to hear that you focus on clang and ignore GCC.

nornagon commented 5 years ago

This is not our decision, we are simply following upstream Chromium.