fix: Update sandbox rules that target 10.13 exactly to target 10.13 and higher (backport: 2-0-x)

electron / libchromiumcontent

Shared library build of Chromium’s Content module

MIT License

485 stars 183 forks source link

fix: Update sandbox rules that target 10.13 exactly to target 10.13 and higher (backport: 2-0-x) #748

Closed miniak closed 5 years ago

miniak commented 5 years ago

Description of Change

Backport https://chromium-review.googlesource.com/c/chromium/src/+/1200184/ Fixes HW video decoding not working when GPU process is sandboxed on macOS 10.14. Follow up to https://github.com/electron/libchromiumcontent/pull/558

Checklist

[x] PR description included and stakeholders cc'd
[x] Patch information is added to appropriate .patches.yaml
[x] script/update runs without error
[x] PR title follows semantic commit guidelines

miniak commented 5 years ago

@nornagon it fixes HW video decoding not working when GPU process is sandboxed on macOS 10.14. Added link to the original PR to the description

MarshallOfSound commented 5 years ago

@miniak 2-0-x is only getting security fixes now afaik, what is the priority for you to upstream this?

Note, not blocking this, just asking for importance / more info

miniak commented 5 years ago

@MarshallOfSound any app playing streaming video using the <video> element on macOS 10.14 would be affected. Upstreaming the fix is not that critical for us, we have a local backport.