fix: network hangs when using DHCP based WPAD (backport: 3-1-x)

electron / libchromiumcontent

Shared library build of Chromium’s Content module

MIT License

485 stars 183 forks source link

fix: network hangs when using DHCP based WPAD (backport: 3-1-x) #749

Closed deepak1556 closed 5 years ago

deepak1556 commented 5 years ago

Description of Change

Backports: https://chromium-review.googlesource.com/c/chromium/src/+/876921/ https://chromium-review.googlesource.com/c/chromium/src/+/946870/

Upstream Issue: https://bugs.chromium.org/p/chromium/issues/detail?id=770201

This is not required to be backported to 3-0-x, since 3-0-x uses the platforms proxy resolver which is the equivalent of using --proxy-resolver-winhttp flag in chrome. And as mentioned in https://bugs.chromium.org/p/chromium/issues/detail?id=770201#c61 users in that config are not affected.

Checklist

[x] PR description included and stakeholders cc'd
[x] Patch information is added to appropriate .patches.yaml
[x] script/update runs without error
[x] PR title follows semantic commit guidelines

deepak1556 commented 5 years ago

Its a direct backport of those CLs, manual intervention was not required.

deepak1556 commented 5 years ago

Forgot to squash and merge, sorry!

bpasero commented 5 years ago

@deepak1556 hey, we are getting increased reports of users that connection of VSCode onto network drives (via UNC path) is slow: https://github.com/Microsoft/vscode/issues/70045. People say this was not happening with 3.1.2.

We did change Electron from 3.1.2 to 3.1.6. Can you recall if any change (such as this one) could have an impact?

bpasero commented 5 years ago

I will conduct a test with our users to use 3.1.2 again with our 1.32 release. Since there is people also complaining on Linux, the root of this issue might be elsewhere. Will report back when I get feedback on how it goes with the previously used 3.1.2

deepak1556 commented 5 years ago

@bpasero I am pretty sure its not caused by this patch. Did vscode change how it loads workspace directories ? There is an upstream issue that seems to reflect the issue described above https://chromium-review.googlesource.com/c/chromium/src/+/1234335/ , the fix got only into 70. If I can get a net-log trace from the users, I can confirm if its the same issue and backport the fix to 3.1.x line.

bpasero commented 5 years ago

@deepak1556 just heard back from users that this reproduces with an older Electron version, so it seems unrelated. We after all just use node.js fs module to read files. I will continue to investigate on the VSCode side. Thanks for the link.