electron / libchromiumcontent

Shared library build of Chromium’s Content module
MIT License
486 stars 183 forks source link

fix: include v8 flags used by electron in ffmpeg build #760

Closed jkleinsc closed 5 years ago

jkleinsc commented 5 years ago
Description of Change

mksnapshot comes from the ffmpeg build and needs the same v8 flags used for the static library build.

Right now without those flags the mksnapshot we are distributing for 3-1-x ends up causing segfaults if you use Promises in the snapshot script. See https://github.com/electron/electron/issues/18420 for more details

Checklist