search

electron / node-abi

:turtle: :rocket: Get the Node.js and Electron ABI for a given target and runtime
https://www.npmjs.com/node-abi
MIT License
164 stars 58 forks source link

Deprecated targets #14

Closed fanatid closed 7 years ago

fanatid commented 7 years ago

Why node v8.0.0 in deprecatedTargets?

juliangruber commented 7 years ago

actually, the name deprecated is misleading here, it means notSupported. Shall we rename it?

lgeiger commented 7 years ago

Instead of renaming (which would mean a new major version) we could instead introduce a new futureTargets object with node v8.0.0. I think that may be the clearest name.

@juliangruber @fanatid What do you think?

fanatid commented 7 years ago

+1 for feature! I also thought about this. I'll do PR for this.