search

electron / node-abi

:turtle: :rocket: Get the Node.js and Electron ABI for a given target and runtime
https://www.npmjs.com/node-abi
MIT License
164 stars 58 forks source link

Add all versions of node/electron & use semver (attempt 2) #21

Closed fanatid closed 7 years ago

fanatid commented 7 years ago

Previous PR: #18 This PR do not need major version bump

fanatid commented 7 years ago

ping :)

lgeiger commented 7 years ago

Sorry for the long wait, I'll try to take a look next week.

lgeiger commented 7 years ago

Hi @fanatid thanks again for your effort! 👍 This adds a lot of complexity to the module. Personally I like to keep the simplicity of the module as is.

The automatic updating of the list is awesome. But for me I think it adds a bit too much complexity to node-abi. At the moment we can just update the list from the GitHub UI on every Node major and every Electron minor version which can be done quite fast.

I don't like the idea of maintaining a complete list of all Node and Electron version (including patch releases) since it would almost always be outdated. We use this module for rebuilding native packages against different ABIs. Therefore we only care about the releases that have an ABI change. What is your use case where you need all the available targets?

lgeiger commented 7 years ago

Closing in favor of #12

Thanks again for your work.