search

electron / node-abi

:turtle: :rocket: Get the Node.js and Electron ABI for a given target and runtime
https://www.npmjs.com/node-abi
MIT License
164 stars 58 forks source link

Bug: Doesn't work with beta versions of electron #38

Closed amilajack closed 6 years ago

amilajack commented 6 years ago 
An unhandled error occurred inside electron-rebuild
Could not detect abi for version 2.0.0-beta.1 and runtime electron.  Updating "node-abi" might help solve this issue if it is a new release of electron

Error: Could not detect abi for version 2.0.0-beta.1 and runtime electron.  Updating "node-abi" might help solve this issue if it is a new release of electron
    at Object.getAbi (/project/node_modules/node-abi/index.js:30:9)
    at new Rebuilder (/project/node_modules/electron-rebuild/lib/src/rebuild.js:64:28)
    at rebuildWithOptions (/project/node_modules/electron-rebuild/lib/src/rebuild.js:310:23)
    at Object.doRebuild [as rebuild] (/project/node_modules/electron-rebuild/lib/src/rebuild.js:317:16)
    at Object.<anonymous> (/project/node_modules/electron-rebuild/lib/src/cli.js:114:33)
    at Generator.next (<anonymous>)
    at /project/node_modules/electron-rebuild/lib/src/cli.js:8:71
    at new Promise (<anonymous>)
    at __awaiter (/project/node_modules/electron-rebuild/lib/src/cli.js:4:12)
    at /project/node_modules/electron-rebuild/lib/src/cli.js:69:8
child_process.js:614
    throw err;

What's the way to fix this?

MarshallOfSound commented 6 years ago

Updating "node-abi" might help solve this issue if it is a new release of electron

amilajack commented 6 years ago

Just checked the source in master and it seems like electron 1.8.0 is the latest supported version

MarshallOfSound commented 6 years ago

@amilajack See https://github.com/lgeiger/node-abi/blob/master/index.js#L94 2.0.0-beta.1 definitely works 👍

lgeiger commented 6 years ago

Just double checked, that this is working correctly in the latest version: https://runkit.com/embed/fcf04gpmoamc