Closed lgeiger closed 6 years ago
@lgeiger Cool. Will this mean a new major version?
Technically this would mean a new major version thought I fear the maintenance effort if releasing a new major for every change in the LTS cycle.
Would you be OK with making this a minor release (since as far as I know only prebuild is affected)?
I fear the maintenance effort if releasing a new major for every change in the LTS cycle.
I don't think it's that often an LTS goes EOL and you still need to make a release either way right? So for node-abi
it's not really different to release a minor or a major. Only means prebuild
will have to update to a new major version of node-abi
and I'm completely fine with that since prebuild
will release a new major either way.
Does that make sense?
@lgeiger Is the date comparison for 10 not wrong? It seems it will compare true < new Date(2020, 4, 31)
which is true
, but not what you want? Or is there a trick that I do not understand?
Version 5.0 of
prebuild-install
dropped support for Node 4 so it doesn't make sense to include it insupportedTargets
since we use this list to determine for wich distributions to build.This commit also updates the LTS schedule.
/cc @ralphtheninja @mafintosh @juliangruber