search

electron / node-abi

:turtle: :rocket: Get the Node.js and Electron ABI for a given target and runtime
https://www.npmjs.com/node-abi
MIT License
164 stars 58 forks source link

fix bug with lts computation for node 10 #59

Closed nornagon closed 5 years ago

nornagon commented 5 years ago

chained comparisons don't work in node, a < b < c is equivalent to (a < b) < c, i.e. coerce the boolean (a < b) to an integer (0 for false, 1 for true) and then compare that to c. So this lts test would always have been true, since both 0 and 1 are less than +new Date(2020, 4, 31)

lgeiger commented 5 years ago

:tada: This PR is included in version 2.7.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: