search

electron / node-abi

:turtle: :rocket: Get the Node.js and Electron ABI for a given target and runtime
https://www.npmjs.com/node-abi
MIT License
164 stars 58 forks source link

added abi version for electron 6 #67

Closed patrickrobbins closed 5 years ago

dsanders11 commented 5 years ago

@MarshallOfSound, @malept, can this or #65 be merged? 6.0.0 is on beta 9 now, and it's a pain to use the beta without this change. Not much point in having a futureTargets if it doesn't get used for something like the betas.

malept commented 5 years ago

Sorry, I don't have commit rights to this repository.

issacgerges commented 5 years ago

Can raise a separate issue on electron-rebuild but it also may be worthwhile to have an optional --abi argument there that could be used to unblock folks in cases like this. Happy to do the work if it's something you want @MarshallOfSound

MarshallOfSound commented 5 years ago

@issacgerges Maybe something like --force-abi=78 or similar, the ABI number is only used to de-dupe / determine when to rebuild 👍

lgeiger commented 5 years ago

:tada: This PR is included in version 2.9.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

dsanders11 commented 5 years ago

Thanks @MarshallOfSound and @lgeiger for pushing it through.