electron / node-abi

:turtle: :rocket: Get the Node.js and Electron ABI for a given target and runtime
https://www.npmjs.com/node-abi
MIT License
164 stars 58 forks source link

Support for electron v6.0.0 #68

Closed thevirajshelke closed 5 years ago

thevirajshelke commented 5 years ago

I have just updated my electron version to 6.0.0. While rebuilding SQLite3 with electron-rebuild I am getting the following error.

An unhandled error occurred inside electron-rebuild
Could not detect abi for version 6.0.0 and runtime electron.  Updating "node-abi" might help solve this issue if it is a new release of electron

Error: Could not detect abi for version 6.0.0 and runtime electron.  Updating "node-abi" might help solve this issue if it is a new release of electron

I am able to rebuild the SQLite package using electron-builder. I am using npx electron-builder install-app-deps.

barryajones commented 5 years ago

I'm not sure but I think we just need to add a new target to the supportedTargets

{runtime: 'electron', target: '6.0.0', abi: '73', lts: false}
thevirajshelke commented 5 years ago

They have updated the package to v2.10.0 & have added support for electron v6.0.0. Closing this issue :)