electron / osx-sign

Codesign Electron macOS apps
BSD 2-Clause "Simplified" License
567 stars 97 forks source link

Rethink --pre-auto-entitlements (merge entitlement entries from provisioning profile) #191

Open sethlu opened 5 years ago

sethlu commented 5 years ago

Here's what electron-osx-sign does a little differently: Since Electron supports macOS features like Handoff, when app sandbox is enabled, electron-osx-sign (default with --pre-auto-entitlements) will automatically inject com.apple.developer.team-identifier into the entitlements to enable these features... and this entry must be whitelisted by a provisioning profile.

Therefore, electron-osx-sign requires provisioning profiles whenever app sandbox is enabled (applicable to MAS development and distribution). They will be picked up automatically if placed in the current working directory.

🤔 I think the this entitlements automation behavior will likely change in a next major release of electron-osx-sign so the presence of provisioning profile should be what adds in the whitelisted entitlement entries, instead of when app sandbox is enabled.

Originally posted by @sethlu in https://github.com/electron-userland/electron-builder/issues/897#issuecomment-487414713

jabetong1 commented 5 years ago

I get the same issue. Is there any enhancement in the entitlements automation?

sethlu commented 5 years ago

@jabetong1 I'm not sure which issue you're encountering, but a solution is discussed in the original comment https://github.com/electron-userland/electron-builder/issues/897#issuecomment-487414713