electron / osx-sign

Codesign Electron macOS apps
BSD 2-Clause "Simplified" License
565 stars 96 forks source link

Invalid ElectronTeamID when certificate name includes extra parentheses #245

Closed daveyjones closed 2 years ago

daveyjones commented 3 years ago

According to these docs:

When using electron-osx-sign the ElectronTeamID key will be added automatically by extracting the Team ID from the certificate's name.

My client's team name includes parentheses:

Acme LLC (US)

So the certificate name looks like this:

3rd Party Mac Developer Application: Acme LLC (US) (1A2B3C4D5E)

This results in the following value for ElectronTeamID:

US) (1A2B3C4D5E

In other words, the regular expression used to parse the team ID doesn't account for the possibility that there may be parentheses in the certificate name itself.