search

electron / osx-sign

Codesign Electron macOS apps
BSD 2-Clause "Simplified" License
565 stars 96 forks source link

Change filtering to treat base Contents directory the same as its subdirectories #247

Open rpatrick00 opened 3 years ago

rpatrick00 commented 3 years ago

In working through a number of issues trying to get electron-builder to sign/notarize my application (which is packaged as a DMG installer), I ran into issues with text files in the Contents directory. I was hopeful when I found the -ignore option (surfaced in electron-builder as signIgnore). Unfortunately, what I found was:

  1. Files in the root MyApp.app/Contents directory cannot be filtered (i.e., the ignore() function is never called for them).
  2. Files in the subdirectories of MyApp.app/Contents are already being filtered (e.g., the ignore() function is never called for MyApp.app/Contents/tools/weblogic-deploy/LICENSE.txt but code signing is skipping the file automatically).

I don't understand the the rationale for this seemingly inconsistent behavior. You can see more details at https://github.com/electron-userland/electron-builder/issues/6085.

brnbs commented 4 months ago

any update on this?