Open mahnunchik opened 9 months ago
Hello,
I've faced with different behavior in @electron/osx-sign v 1.0.5 vs electron-osx-sign v 0.5.0.
@electron/osx-sign
electron-osx-sign
If options provisioningProfile and preEmbedProvisioningProfile are not specified (preEmbedProvisioningProfile is true by default) then default embedded.provisionprofile is used here https://github.com/electron/osx-sign/blob/06b32b5e8955c95203882ff7ae7f08ae84764a26/src/util-provisioning-profiles.ts#L108-L111 and successfully embedded here https://github.com/electron/osx-sign/blob/06b32b5e8955c95203882ff7ae7f08ae84764a26/src/util-provisioning-profiles.ts#L124 after executing https://github.com/electron/osx-sign/blob/06b32b5e8955c95203882ff7ae7f08ae84764a26/src/sign.ts#L381C11-L381C38
provisioningProfile
preEmbedProvisioningProfile
embedded.provisionprofile
But the following sign application action https://github.com/electron/osx-sign/blob/06b32b5e8955c95203882ff7ae7f08ae84764a26/src/sign.ts#L404 doesn't use it here https://github.com/electron/osx-sign/blob/06b32b5e8955c95203882ff7ae7f08ae84764a26/src/sign.ts#L226-L228 because validatedOpts.provisioningProfile is undefined as it is in original options.
validatedOpts.provisioningProfile
electron-osx-sign filled out the options with the correct profile https://github.com/electron/osx-sign/blob/v0.5.0/util-provisioning-profiles.js#L172
options
The same for identity
identity
Hello,
I've faced with different behavior in
@electron/osx-sign
v 1.0.5 vselectron-osx-sign
v 0.5.0.If options
provisioningProfile
andpreEmbedProvisioningProfile
are not specified (preEmbedProvisioningProfile
is true by default) then defaultembedded.provisionprofile
is used here https://github.com/electron/osx-sign/blob/06b32b5e8955c95203882ff7ae7f08ae84764a26/src/util-provisioning-profiles.ts#L108-L111 and successfully embedded here https://github.com/electron/osx-sign/blob/06b32b5e8955c95203882ff7ae7f08ae84764a26/src/util-provisioning-profiles.ts#L124 after executing https://github.com/electron/osx-sign/blob/06b32b5e8955c95203882ff7ae7f08ae84764a26/src/sign.ts#L381C11-L381C38But the following sign application action https://github.com/electron/osx-sign/blob/06b32b5e8955c95203882ff7ae7f08ae84764a26/src/sign.ts#L404 doesn't use it here https://github.com/electron/osx-sign/blob/06b32b5e8955c95203882ff7ae7f08ae84764a26/src/sign.ts#L226-L228 because
validatedOpts.provisioningProfile
is undefined as it is in original options.