electron / osx-sign

Codesign Electron macOS apps
BSD 2-Clause "Simplified" License
558 stars 96 forks source link

docs: Update requirements in readme #300

Closed felixrieseberg closed 7 months ago

felixrieseberg commented 7 months ago

I discovered today that passing in designated requirements as a string did not work - whereas the exact same string in a text file did indeed work. This PR fixes that in our README.

Works:

osxSign: {
  identity: 'Developer ID Application: Felix Rieseberg (LT94ZKYDCJ)',
  optionsForFile: (filePath) => {
    entitlements: 'static/entitlements.plist',
    requirements: path.resolve(__dirname, 'tools/certs/requirements.txt'),
  },
}

Does not work:

osxSign: {
  identity: 'Developer ID Application: Felix Rieseberg (LT94ZKYDCJ)',
  optionsForFile: (filePath) => {
    entitlements: 'static/entitlements.plist',
    requirements: 'designated => anchor apple generic and certificate 1[field.1.2.840.113635.100.6.2.6] /* exists */ and certificate leaf[field.1.2.840.113635.100.6.1.13] /* exists */ and ( certificate leaf[subject.OU] = LT94ZKYDCJ or certificate leaf[subject.OU] = UY52UFTVTM )'
  },
}
continuous-auth[bot] commented 4 months ago

:tada: This PR is included in version 1.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: