electron / osx-sign

Codesign Electron macOS apps
BSD 2-Clause "Simplified" License
565 stars 96 forks source link

feat: add Use deep flag 😋 #240 #303

Closed PBK-B closed 4 months ago

PBK-B commented 8 months ago

This is a lightweight solution for https://github.com/electron/osx-sign/issues/240 issue. By adding the optional parameter useDeepFlag to OnlySignOptions to meet the needs of some people to add the codesign --deep identification, and configure the default value to false and explain the possible impact of this parameter in README. I think this should be an acceptable to most people. If you have any questions, please reply. I look forward to promoting this problem ⭐️.

Related links: https://github.com/electron/osx-sign/pull/267 https://github.com/electron/osx-sign/pull/231 https://github.com/electron/osx-sign/issues/229

Many predecessors have encountered this problem and tried to discuss and solve it clearly. Thank them for their work 👏.

fixed https://github.com/electron/osx-sign/issues/240

cc @sethlu @MarshallOfSound