search

electron / osx-sign

Codesign Electron macOS apps
BSD 2-Clause "Simplified" License
558 stars 96 forks source link

chore: bump fs-extra from 10.0.0 to 11.2.0 #321

Open threema-danilo opened 1 month ago

threema-danilo commented 1 month ago

@erickzhao hi! Yes, the reason is that we were having issues with the NodeJS version resolution algorithm in combination with local file: dependencies. For some reason, NodeJS would resolve fs-extra to a different version than the one required by our local library.

Upon closer inspection I noticed that there were about 4 different versions of fs-extra included in the various electron libs. I hoped that bringing the versions more in line would help.

we generally don't accept dependency bump PRs from outside contributors

That's fine, but I'd like to note that some of the libraries still contain very old dependencies, like TypeScript 4.0 in electron/rebuild. Some libs also declare compatibility with Node 10, where LTS security support ended more than 3 years ago. Some maintenance there would make non-dependency-bump contributions easier.

erickzhao commented 1 month ago

Thanks for the clarification! Will bring this up to other maintainers as well and hopefully have some forward momentum on this. :)