electron-packager does not recognize 64-bit wine installations that do not include the wine64 command

hexaheximal commented 1 year ago

Preflight Checklist

[x] I have read the contribution documentation for this project.
[x] I agree to follow the code of conduct that this project follows, as appropriate.
[x] I have searched the issue tracker for a bug that matches the one I want to file, without success.

Issue Details

Electron Packager Version:
- 17.1.1
Electron Version:
- 24.3.1
Operating System:
- Debian 12 (bookworm) amd64

Expected Behavior

With 64-bit WINE installed via apt, it should build without any issues.

Actual Behavior

electron-packager checks for wine64, and fails to find it as debian does not package the wine64 command.

To Reproduce

Create an electron-packager app on Debian 12 (bookworm), install wine, and build for the win32 target.

Additional Information

An easy workaround for this issue is to simply create a wrapper script in the $PATH with the name wine64 that simply runs the regular wine command and passes the arguments provided to the script.

welcome[bot] commented 1 year ago

👋 Thanks for opening your first issue here! If you have a question about using Electron Packager, read the support docs. If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. Development and issue triage is community-driven, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing guidelines.

Properko commented 1 year ago

I've had a similar issue with wine not working in our kubernetes/jenkins environment, but wine64 working fine. I had no control on what electron-builder uses though, so I symlinked wine to wine64 via ln -sf /usr/bin/wine64 /usr/bin/wine

campersau commented 2 months ago

Upstream issue: https://github.com/electron/windows-installer/issues/513