error when packageConfig.tmpdir set to false

[ianho]

Pre-flight checklist

• [X] I have read the contribution documentation for this project.
• [X] I agree to follow the code of conduct that this project uses.
• [X] I have searched the issue tracker for a bug that matches the one I want to file, without success.

Electron Forge version

7.2.0

Electron version

27.1.2

Operating system

maxOS 13.2.1

Last known working Electron Forge version

No response

Expected behavior

no error when packageConfig.tmpdir set to false

Actual behavior

When packageConfig.tmpdir set to false, will get the error below: Error: Cannot copy '/path/to/project' to a subdirectory of itself, '/path/to/project/out/AppName***/Electron.app/Contents/Resources/app'.

This error was thrown by fs-extra, whem electron-packager try to copy project to the out dir.

Thats caused by out dir is not allowed to set, so out dir must be a subdirectory

I want to take a PR for this, but there are 3 ways to fix it, I dont know we prefer which one

1. when user set tmpdir to false, overwrite it to undefined, https://github.com/electron/forge/pull/3476
2. when user set tmpdir to false, throw an error by forge, https://github.com/electron/forge/pull/3477
3. make electron-packager fix this problem, I also take a PR for this way: https://github.com/electron/packager/pull/1657

If we choose 1 or 2, I will take the PR soon

Steps to reproduce

set packageConfig.tmpdir to false run forge package

Additional information

No response

[BlackHole1]

Thank you for your feedback. Personally, I am more inclined towards the third solution because the first two options are merely temporary measures that do not address the underlying issue.

[welcome[bot]]

👋 Thanks for opening your first issue here! If you have a question about using Electron Packager, read the support docs. If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. Development and issue triage is community-driven, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing guidelines.

[BlackHole1]

PTAL @electron/forgers

[erickzhao]

Discussed in an @electron/wg-ecosystem meeting, going with option 3 and moving this to packager.