electron / packager

Customize and package your Electron app with OS-specific bundles (.app, .exe, etc.) via JS or CLI
https://npm.im/@electron/packager
BSD 2-Clause "Simplified" License
161 stars 17 forks source link

Incorrect error message when --out is set to the folder containing the entry point #1685

Open Renpona opened 7 months ago

Renpona commented 7 months ago

Preflight Checklist

Issue Details

Expected Behavior

If the --out flag is used to set the target directory to the same directory that contains the entry point, then running electron-packager should present an error message explaining that this is not supported.

Actual Behavior

If the --out flag is used to set the target directory to the same directory that contains the entry point, then running electron-packager will result in a "The main entry point to your app was not found" error message, which does not correctly identify the problem.

To Reproduce

Create a directory structure like this:

root/
    package.json
    /dist
        code.js

In package.json, set the entry point with "main" to "dist/code.js", "./dist/code.js", or "dist\code.js".

Now run electron-packager with the command-line

electron-packager . test --platform win32 --out ./dist

The error it will return is:

The main entry point to your app was not found. Make sure "dist\code.js" exists and does not get ignored by your ignore option

This is a misleading error message for the user, however, as changing the --out target to a different directory resolves the problem.

welcome[bot] commented 7 months ago

šŸ‘‹ Thanks for opening your first issue here! If you have a question about using Electron Packager, read the support docs. If you're reporting a šŸž bug, please make sure you include steps to reproduce it. Development and issue triage is community-driven, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing guidelines.