Closed rickymohk closed 2 weeks ago
Thanks for opening a pull request!
Here are some highlighted action items that will help get it across the finish line, from the pull request guidelines:
npm run lint
locally to catch formatting errors earlier.NEWS.md
and other docs.Development and triage is community-driven, so please be patient and we will get back to you as soon as we can.
Attention: Patch coverage is 0%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 89.06%. Comparing base (
00d20b9
) to head (7ecc0d8
).
Files | Patch % | Lines |
---|---|---|
src/win32.ts | 0.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The test failure is unrelated and exists on main, merging.
Thanks for your contribution! 🎉
:tada: This PR is included in version 18.3.3 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
Summarize your changes: Fixing windows-sign does not work due to
appDirectory
missing.