electron / packager

Customize and package your Electron app with OS-specific bundles (.app, .exe, etc.) via JS or CLI
https://npm.im/@electron/packager
BSD 2-Clause "Simplified" License
123 stars 11 forks source link

fix: appDireactory missing for windows-sign options #1731

Closed rickymohk closed 2 weeks ago

rickymohk commented 1 month ago

Summarize your changes: Fixing windows-sign does not work due to appDirectory missing.

welcome[bot] commented 1 month ago

Thanks for opening a pull request!

Here are some highlighted action items that will help get it across the finish line, from the pull request guidelines:

Development and triage is community-driven, so please be patient and we will get back to you as soon as we can.

codecov[bot] commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 89.06%. Comparing base (00d20b9) to head (7ecc0d8).

Files Patch % Lines
src/win32.ts 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1731 +/- ## ======================================= Coverage 89.06% 89.06% ======================================= Files 17 17 Lines 905 905 Branches 187 187 ======================================= Hits 806 806 Misses 62 62 Partials 37 37 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

felixrieseberg commented 2 weeks ago

The test failure is unrelated and exists on main, merging.

welcome[bot] commented 2 weeks ago

Thanks for your contribution! 🎉

continuous-auth[bot] commented 2 weeks ago

:tada: This PR is included in version 18.3.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: