search

electron / rcedit

Command line tool to edit resources of exe
MIT License
1.71k stars 190 forks source link

fix: loadwrong chars at head of the manifest. #78

Closed LnsooXD closed 6 years ago

LnsooXD commented 6 years ago

when load manifest from electron exe(2.0.9) on the windows 10 , there whill be some unexcepted chars at the head. This will cause the target exe broken

image

LnsooXD commented 6 years ago

This problem can also be found at here: https://github.com/electron-userland/electron-builder/issues/2936

LnsooXD commented 6 years ago

Could you please take a look at this PR? Or there is a batter solution? @zcbenz

zcbenz commented 6 years ago

I think we should strip the BOM char instead of doing a simple string search, but this is working good enough.