Closed DutchKevv closed 7 years ago
MarshallOfSound
commented
7 years ago I don't see how the changeset could cause this error, the only thing that could potentially cause this is the bump in node-gyp dependency from ^3.4.0 to ^3.6.0 which should be the same thing really. 😕
https://github.com/electron/electron-rebuild/compare/v1.5.7...master?expand=1
Can you isolate the exact version it breaks, try 1.5.8,9,10 as well 👍
DutchKevv
commented
7 years ago Hi @MarshallOfSound thanks for the quick reply!
I'm looking at it right now, but also a quick update:
The same error happened to me about a week ago, then I did the same thing
But for some reason 1.5.7 now keeps giving me this same error, even I revert everything.. So I suspect something else is wrong at my end. Although it strange cause I worked an hour ago before I updated the packages... Maybe another package is doing wrong things.
Will keep you updated!!
MarshallOfSound
commented
7 years ago Sounds like an issue with another package but I'll leave it open for now 😄
DutchKevv
commented
7 years ago Haha guess so.. Sorry to bump you with it! Give me 24 hours to see whats going on (y)
DutchKevv
commented
7 years ago Hmm okay found the direction of the problem, but don't really understand whats going on underwater...
The problem is with the socket.io package... 1.7.3 worked fine, @latest (2.0.1) fails..
It starts with this error
An unhandled error occurred inside electron-rebuild ENOENT: no such file or directory, open 'C:\Users\Kewin\Projects\TradeJS\server\node_modules\uws\package.json'
Error: ENOENT: no such file or directory, open 'C:\Users\Kewin\Projects\TradeJS\server\node_modules\uws\package.json'
What is strange, because the uws folder gets created everytime I run npm i (think node-gyp creates it). But sometimes this folder is almost empty. When I remove the folder by hand and run npm i again.. Then the uws folder is created like normal module (with package.json etc) and then the error shows up given in the original comment.
So its related to socket.io module, but my knowledge (and time) are not big enough to dig very deep. Everything works fine with every electron-rebuild version, as long as I stay below socket.io < v2.
Thanks and sorry for the false alarm!
DutchKevv
commented
7 years ago Here is the full (none-working) package.json for later reference:
{
"name": "tradejs",
"version": "0.0.11",
"description": "Javascript Trading Client",
"email": "kewin@frontend-freelance.com",
"author": "Kewin Brandsma",
"private": false,
"license": "Apache License 2.0",
"repository": {
"type": "git",
"url": "https://github.com/DutchKevv/TradeJS.git"
},
"keywords": [
"TradeJS",
"Stock",
"Forex",
"Trade",
"Trading",
"Node",
"Trading",
"NodeJS"
],
"scripts": {
"postinstall": "electron-rebuild -w sqlite3 -v 1.6.6 && node copy-sql3-binary.js --version=53",
"start": "cross-env DEBUG=TradeJS:* gulp server:dev --web",
"lint": "gulp tslint",
"dist": "build",
"build": "gulp server:build",
"build:custom": "gulp custom:build",
"prod": "cross-env NODE_ENV=production node dist/server/bin/www.js",
"__temp-node-ipc": "git://github.com/RIAEvangelist/node-ipc.git#v9.x"
},
"dependencies": {
"backbone-events-standalone": "0.2.7",
"body-parser": "1.17.1",
"cli-table": "0.3.1",
"cors": "2.8.3",
"cross-env": "^5.0.0",
"debug": "^2.6.6",
"deepmerge": "1.3.2",
"directory-tree": "1.2.1",
"electron-rebuild": "^1.5.11",
"event-stream": "*",
"express": "4.15.2",
"freeport": "1.0.5",
"gulp": "3.9.1",
"gulp-sourcemaps": "2.6.0",
"gulp-tslint": "8.0.0",
"gulp-typescript": "3.1.6",
"lodash": "4.17.4",
"minimist": "1.2.0",
"mkdirp": "0.5.1",
"moment": "*",
"node-ipc": "git://github.com/RIAEvangelist/node-ipc.git#v9.x",
"node-watch": "^0.5.4",
"nodemon": "1.11.0",
"readable-timespan": "1.2.0",
"request": "2.81.0",
"rmdir": "1.2.0",
"run-sequence": "1.2.2",
"socket.io": "^2.0.1",
"source-map-support": "0.4.14",
"sqlite3": "^3.1.8",
"sqlite3-transactions": "0.0.5",
"tree-kill": "1.1.0",
"tslint": "5.1.0",
"typescript": "2.3.2",
"watch": "1.0.2"
},
"devDependencies": {
"@types/body-parser": "1.16.3",
"@types/compression": "0.0.33",
"@types/cors": "2.8.1",
"@types/debug": "0.0.29",
"@types/express": "4.0.35",
"@types/freeport": "1.0.21",
"@types/lodash": "4.14.62",
"@types/minimist": "1.2.0",
"@types/mkdirp": "0.3.29",
"@types/moment": "2.13.0",
"@types/node": "7.0.12",
"@types/socket.io": "1.4.29",
"@types/socket.io-client": "1.4.29",
"@types/sqlite3": "2.2.33"
}
}
arximboldi
commented
6 years ago @DutchKevv I am hitting this right now. Did you manage to fix this somehow? Reverting to socket.io 1.7 is not an option for me... :(
After updating to 1.5.11 windows give trouble about missing openSSL (probably when compiling sqllite3). When I downgrade 1.5.7 all works fine again.
I removed the node_modules foler and reinstalled everyting to give it a fresh shot, but didn't help.
Is it a hard dependency now to have openSSL installed on windows machines??
Thanks!
Here is the console log ->