electron / releases

📦 Complete and up-to-date info about every release of Electron
MIT License
245 stars 38 forks source link

Past few 19.beta releases are missing #171

Closed baparham closed 2 years ago

baparham commented 2 years ago

It seems that the beta channel releases have stopped updating after 19.0.0-beta.4, missing betas 5-7.

Is this expected to happen until some other event triggers a sync of the data?

baparham commented 2 years ago

Oh, I see, the latest actions have been failing, so they probably aren't updating the data back into the library.

https://github.com/electron/releases/runs/6483830096?check_suite_focus=true

What help do you need to fix this issue?

baparham commented 2 years ago

v20.0.0-nightly.20220516 seems to be missing the deps property, which is making the tests fail. I am not sure if this is the only failing release since the test may short circuit after hitting this failure...I'm not sure.

[edit] Perhaps because that version seems to be missing from the https://electronjs.org/headers/index.json file ?

What's the right solution here...If a version is missing from that headers/index.json file, should it be ignored for the purposes of the tests or something? Perhaps have some flag set in the releases json object to indicate that something else is wrong with that particular release?

erickzhao commented 2 years ago

Checking internally to fix the headers/index.json issue while developing a workaround for this problem at the level of this package. Thanks for the report!

erickzhao commented 2 years ago

We fixed this upstream last week!