search

electron / sheriff

Controls and monitors organization permissions across GitHub, Slack and GSuite. Built with ❤️ by The Electron Team
MIT License
140 stars 20 forks source link

Non-blocking Runs #42

Closed onlydole closed 1 year ago

onlydole commented 1 year ago

Howdy, team! It would be wonderful to have the ability to have Sheriff run and "continue on error" if there are folks not added to an Org yet, and continue to enforce the configuration as code that has been set.

Right now, if there's someone that's pending an org invite, it blocks any other operations from completing.

MarshallOfSound commented 1 year ago

This makes sense for the inverse case (where someone leaves the org). If someone leaves the org it shouldn't block permission runs.

For the case you outlined where they haven't joined yet I'd strongly recommend either running a Sheriff Dry Run on each PR or using something similar to what we use on electron/.permissions --> https://github.com/codebytere/governance-check which does a fast-pass of the config file and ensures it's loose validity (including verifying org membership)

onlydole commented 1 year ago

Thank you, @MarshallOfSound! That's exactly what I was looking for 😁