search

electron / symbolicate-mac

Symbolicate macOS Electron crash reports
ISC License
31 stars 14 forks source link

build: fix broken CI configuration #13

Closed erickzhao closed 2 years ago

erickzhao commented 2 years ago

CI is broken. This PR fixes it.

This PR has 4 distinct changes:

499cf63 bumps xcode to 12.4.0. de20bdf updates the Jest snapshots to work with the updated xcode version. 5745ef7 small orthogonal refactor: refactors out a deprecated Node.js API. 94bd4b1 removes a TODO by handling the symbol download in JS, which solves a curl issue in CI.

erickzhao commented 2 years ago

Added a separate commit here that fixes some formatting issues: 8e7a48a

This is temporary and I did it manually. This repo should probably have some form of linting set up in the future.

electron-bot commented 2 years ago

:tada: This PR is included in version 2.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: