search

electron / trop

automate the backporting process
MIT License
73 stars 31 forks source link

Support Heroku-24 Stack #303

Closed dsanders11 closed 1 week ago

dsanders11 commented 3 weeks ago

The Heroku-24 stack removes Git at runtime which is problematic since trop needs it. So we need to tweak our usage of Heroku here to ensure Git is present. In the meantime we're trying to stay pinned to the Heroku-22 stack.

We may also want to add a check for Git early on and fail more loudly if it's not found. Currently the failure mode is somewhat silent and just goes down the unable to automatically backport path.

erickzhao commented 3 weeks ago

I think the path forward according to this Help Centre ticket would be to use heroku-buildpath-apt in combination with a multi-buildpack setup to essentially apt-get install git in the Heroku image.