search

electron / universal

Create Universal macOS applications from two x64 and arm64 Electron applications
MIT License
112 stars 43 forks source link

fix: merged ASAR does not unpack when there is only one unpacked file #55

Closed quanglam2807 closed 1 year ago

quanglam2807 commented 1 year ago

Pattern {file1,file2} only works with multiple files. minimatch does not recognize pattern {file1} so if user only has one unpacked file, asar will not unpack it.

Resolve https://github.com/electron/universal/issues/54

MarshallOfSound commented 1 year ago

@quanglam2807 please sign in to app.circleci.com and re-push your commit so that CI runs

quanglam2807 commented 1 year ago

@MarshallOfSound Job was rejected because resource class medium, image xcode:12.2.0 is not a valid resource class

quanglam2807 commented 1 year ago

@MarshallOfSound Did I miss anything? I couldn't make CircleCI run :(

MarshallOfSound commented 1 year ago

@quanglam2807 rebase on latest master it should be good now 👍

continuous-auth[bot] commented 1 year ago

:tada: This PR is included in version 1.3.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: