search

electron / universal

Create Universal macOS applications from two x64 and arm64 Electron applications
MIT License
112 stars 43 forks source link

fix: ignore differences caused by merged machO files #66

Closed macdja38 closed 8 months ago

macdja38 commented 1 year ago

Problem Description:

Once the strategy to merge the files succeeds we know the MachO files we've generated can run on both arm64 and x64. One interesting quirk here is @electron/universal only modifies the temp folder MachO files. It doesn't touch the arm64 folder. That becomes a problem when the arm64 folder is compared with the temporary folder. @electron/universal has modified the MachO files in the temp folder. So they should certainly be different from the ones in the arm64 folder.

Solution Description:

This PR ads a set of files that @electron/universal merged, and then checks the results of the compare to specifically check that files other than the merged MachO files are different.

continuous-auth[bot] commented 8 months ago

:tada: This PR is included in version 2.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: