search

electron / universal

Create Universal macOS applications from two x64 and arm64 Electron applications
MIT License
112 stars 43 forks source link

singleArchFiles minimatch doesn't work for files in .webpack folder #75

Open jjeff opened 1 year ago

jjeff commented 1 year ago

By default, Webpack puts its files in a folder called .webpack. Then Electron Forge bundles these files into your app package.

However, without the "dot" option, minimatch ignores any files in this "hidden" directory. This means I get errors like the following:

[FAILED] Detected unique file ".webpack/main/index-x64.jsc" in "/var/folders/y2/m0k2q_mn2_jb9tm37k1wds1r0000gn/T/electron-universal-NzIpvm/Tmp.app/Contents/Resources/app.asar" not covered by allowList rule: "**/*.jsc"

I believe this can be fixed by adding dot: true to the minimatch options in checkSingleArch() function in asar-utils.ts.

jjeff commented 1 year ago

I've solved my error by switching my rule from **/*.jsc to *.jsc which works because matchBase is enabled in checkSingleArch(). But the above still feels like a bug.

erickzhao commented 1 month ago

I think that'd be functionally identical to {.*,*}/**/*.jsc with dot: false as well. I personally would prefer to keep dot: false since it's the default for minimatch.