search

electron / website

:electron: The Electron website
https://electronjs.org
Apache License 2.0
112 stars 126 forks source link

Highlight the features in the Home Page #523

Closed ConnectBhawna closed 6 months ago

ConnectBhawna commented 6 months ago

Description of Issue

Presently, the features are visible on the website but lack sufficient emphasis. Consequently, the presentation appears unattractive and lacks a professional touch on both desktop and mobile views, giving it the appearance of a simple website.

To observe this behavior:

  1. Navigate to 'https://www.electronjs.org/'
  2. Observe the features and note their presentation, which is not encapsulated within a distinct box. Screenshot from 2024-02-23 17-33-21

Expected behavior

I am considering placing the features within a box under the div to enhance visibility in both light and dark modes.

To achieve this, I plan to add specific properties in the _index.module.scss file. I have attached a screenshot illustrating how the layout will appear after implementing these changes.

Screenshot from 2024-02-23 17-11-10 Screenshot from 2024-02-23 17-11-04

ConnectBhawna commented 6 months ago

Hello @dsanders11,@VerteDinde & @erickzhao Sir, I'm delving into the electron codebase and believe there's room for improvement in a specific section. Before initiating a pull request, I thought it would be beneficial to have a preliminary discussion with the maintainers. What are your thoughts on this approach? Let me know your feedback.

Let me know if it looks good, I would be happy to create my first PR around the same in Electron.

erickzhao commented 6 months ago

Hey @ConnectBhawna, thanks for your interest in improving the Electron website. Design is very subjective, but I don't think this is a net positive change.

dsanders11 commented 6 months ago

Hi @ConnectBhawna, thanks for taking the initiative to create an issue! 🙂 I agree with @erickzhao that this is a subjective change, and I prefer it the way it currently is.

Issues and PRs are welcome, but minor subjective design tweaks are generally not what we're looking for since they're easy to bikeshed on.

ConnectBhawna commented 6 months ago

Okk thanks for the feedback will take care of this next time from my end .

ConnectBhawna commented 6 months ago

Hey @dsanders11 & @erickzhao sir, is there any community channel like slack , discord and all where we can connect with the mentors and discuss the issues before opening?

dsanders11 commented 6 months ago

@ConnectBhawna, if you're referring to GSoC 2024, you can direct any specific questions to summer-of-code@electronjs.org.