search

electron / windows-installer

Build Windows Installers for Electron apps
MIT License
1.55k stars 259 forks source link

"'Default' tag requires a nonempty 'Extension' attribute" on Win10 #12

Open fcurella opened 8 years ago

fcurella commented 8 years ago

I'm trying to build an installer, but when I try to run it the installation fails with 'Default' tag requires a nonempty 'Extension' attribute:

2016-02-25 08:03:31> IEnableLogger: Failed to create uninstaller registry entry: System.Xml.XmlException: 'Default' tag requires a nonempty 'Extension' attribute. Line 10, position 4.

I've done some googling around and it appears to be an issue with files without extensions.

The template.nuspec tries to create a LICENSE file. Removing the relevant line from <files> seems to resolve the problem.

If you think it's ok to not have that LICENSE file, I can easily submit a PR.

fcurella commented 8 years ago

ref https://github.com/Squirrel/Squirrel.Windows/issues/580

anaisbetts commented 8 years ago

le sigh, fucking Microsoft. In the meantime, building installers on Windows (use AppVeyor if you don't have access to it) will solve this

fcurella commented 8 years ago

@paulcbetts to clarify, your plan is to wait until this is fixed in Squirrel.Windows? (not complaining, just need to know so I can plan around :) )

anaisbetts commented 8 years ago

@fcurella So, this bug only happens when you build a Windows installer with OS X or Linux because of a bug in NuGet (the C# version of RubyGems / npm / etc). If you build an installer with Windows as the host OS, it'll Just Work

fcurella commented 8 years ago

@paulcbetts that means you'd rather wait for the bug to be properly fixed in NuGet, correct?

anaisbetts commented 8 years ago

@fcurella No, you just need to use Windows to build your installer. We're probably going to work around this in Squirrel, but in the meantime, if you want to get your stuff working today, using Windows to build installers will solve this

fcurella commented 8 years ago

Thanks for clarifying @paulcbetts :+1:

FWIW for now I got it working just by editing my local copy of template.nuspec. I'm not familiar with developing on Windows, so that was much quicker for me.

jprichardson commented 8 years ago

FWIW for now I got it working just by editing my local copy of template.nuspec. I'm not familiar with developing on Windows, so that was much quicker for me.

@fcurella can you elaborate on what you changed in template.nuspec? Thanks.

fcurella commented 8 years ago

@jprichardson I've simply removed the line mentioning LICENSE: https://github.com/electron/windows-installer/blob/master/template.nuspec#L22

Mercieral commented 8 years ago

Is there any update on if someone is working on this issue or if it will be fixed any time soon?

develar commented 8 years ago

@Mercieral Try electron-builder ;)