search

electron / windows-installer

Build Windows Installers for Electron apps
MIT License
1.57k stars 263 forks source link

fix: Corrected the verification of Mono and Wine installation status #488

Closed BitYoungjae closed 11 months ago

BitYoungjae commented 11 months ago

The old code wrongly checked if Mono and Wine were installed. It looked like this:

https://github.com/electron/windows-installer/blob/073930d4845432adb2f16891c81066249cf99c71/src/index.ts#L26-L40

The part (!wineExe || !monoExe) didn't work right because wineExe and monoExe were just text, not real checks.

Now, the code really checks if Wine and Mono are there. This fix makes sure the setup works right and checks everything needed.

continuous-auth[bot] commented 11 months ago

:tada: This PR is included in version 5.1.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: