search

electronic-structure / SIRIUS

Domain specific library for electronic structure calculations
BSD 3-Clause "New" or "Revised" License
127 stars 40 forks source link

[enhancement] new implementation of Periodic_function class #816

Closed toxa81 closed 1 year ago

toxa81 commented 1 year ago

cscs-ci run default

electronic-structure commented 1 year ago

cscs-ci run default

toxa81 commented 1 year ago

cscs-ci run default

toxa81 commented 1 year ago

@mtaillefumier I observe a general probelem with squash commits. I rebased to develop and now I have in one single commit changes from all previous commits. Basically, if I work on a frature in a new branch, I can't rebase or merge from the base branch from which I started.

toxa81 commented 1 year ago

I will have to close this one, start again and cherry pick the modifications that are necessary.