search

electronic-structure / SIRIUS

Domain specific library for electronic structure calculations
BSD 3-Clause "New" or "Revised" License
121 stars 40 forks source link

Update clang-format? #897

Closed RMeli closed 10 months ago

RMeli commented 11 months ago

The clang-format.x script uses clang-format-12:

https://github.com/electronic-structure/SIRIUS/blob/84a71b78c5fa964a78cffb0d4878874b15b107f0/clang_format.x#L5

clang-format-12 is rather old (and no longer available via apt in Ubuntu 23). Should the clang-format version be updated?

Commits can be ignored in the blame view.

simonpintarelli commented 11 months ago

I'm using .clang-format via the IDE. But it seems indeed that ubuntu is not adding a symlink called clang-format (unless /usr/lib/llvm-[ver]/bin is in the path:

https://packages.ubuntu.com/kinetic/amd64/clang-format-15/filelist

RMeli commented 10 months ago

Fixed by #918