Closed RMeli closed 11 months ago
cscs-ci run default
Thanks @RMeli . Afaik the full scalapack eigensolver is not used in the code, only the routines which find n-lowest eigenvalues.
I don't like the reinterpret_cast
in the if(std::is_same<T, X>::value)
, we can now actually use constexpr if
. ~I'll try to fix it in a separate PR.~
Ah actually, we can first merge this PR and then I can work on the rest, there are numerous reinterpret_casts to be removed ...
the full scalapack eigensolver is not used in the code
If it's not used another approach would be to remove it?
I don't like the
reinterpret_cast
in theif(std::is_same<T, X>::value)
, we can now actually use constexpr if.
Good point. Now that we use C++17 we could also use the less verbose std::is_same_v
instead.
While working on DLA-Future integration in SIRIUS, I stumbled upon what looks like a spurious recursion. Fixing it also uncovered some missing
reinterpret_cast
insolve_
(for the eigenvalues and the workspace).