search

electronic-structure / SIRIUS

Domain specific library for electronic structure calculations
BSD 3-Clause "New" or "Revised" License
121 stars 40 forks source link

for compatibility to gcc-13 #902

Closed yizeyi18 closed 9 months ago

yizeyi18 commented 10 months ago

Added #include to certain files for compatibility to gcc-13.

toxa81 commented 10 months ago

cscs-ci run default

toxa81 commented 10 months ago

Dear @yizeyi18 sorry for late repy. Can you plese do the same PR, but base it on develop branch. Or, do you need this change in master branch?

yizeyi18 commented 10 months ago

Dear@toxa81 Sorry, I am new to github and don't know how to change its branch. Can you help to move it? This change is just for compatibility with gcc-13 and I missubmitted it to master branch. Sorry.

simonpintarelli commented 10 months ago

The develop branch doesn't need modifications, cstdint includes have been added before, it compiles with gcc13.

yizeyi18 commented 10 months ago

The develop branch doesn't need modifications, cstdint includes have been added before, it compiles with gcc13.

seems src/SDDK/memory.hpp had not added yet. Does it really compiles with gcc-13? I only tried release-7.4.3 and it does not.

simonpintarelli commented 10 months ago

@yizeyi18 Yes, including cstdint in typedefs.hpp is enough to make it compile.

The target branch can be changed using the Edit button next to the title. You would have to rebase your commits to the develop branch first.

PS: In order to be correct, cstdint would have to be included in every file where unitX_t is referenced, these would be a few more according to grep.