Pin DLA-Future version in Spack package with some fixes and improvements

RMeli commented 10 months ago

Pin DLA-Future to freshly released version 0.3.0

Improvements

Enable dlaf variant only with @develop
Change repo name from sirius to sirius-repo to avoid confusion with package name

Fixes:

Add SIRIUS_USE_DLAF so that spack install sirius+dlaf actually works
- Previously I only used the package to manage dependencies, so I missed this
Remove SIRIUS_ prefix from BUILD_SHARED_LIBS

pika+cuda sets INTERFACE_POSITION_INDEPENDENT_CODE=ON, therefore it is incompatible with the hard-coded PISITION_INDEPENEDENT_CODE=OFF in some of the apps/utils. I removed this constraint, but I'm not sure why it was there in the first place.

mtaillefumier commented 10 months ago

I would put POSITION_INDEPENDENT_CODE=ON. If applications still rely on POSITION_INDEPENDENT_CODE=OFF then they should be fixed.... There is no penalty in using POSITION_INDEPENDENT_CODE=ON by default with both static (.a) and dynamic libraries (.so).

RMeli commented 10 months ago

I would put POSITION_INDEPENDENT_CODE=ON

@mtaillefumier, I think this is indeed the case (implicitly)? https://github.com/electronic-structure/SIRIUS/blob/76cc9ab0e8f9f108d8a8966cd8a4e3cf020f468a/CMakeLists.txt#L57

mtaillefumier commented 10 months ago

then all good.

electronic-structure / SIRIUS

Pin DLA-Future version in Spack package with some fixes and improvements #923