search

electronicarts / CnC_Remastered_Collection

Other
18.31k stars 4.74k forks source link

GPL violation / Wrong License #78

Open krux02 opened 4 years ago

krux02 commented 4 years ago

The GPL license declares corresponding source to include all source code that is required to run the object code.

https://github.com/electronicarts/CnC_Remastered_Collection/blob/d9e287e08b3e2fb3e46690d1029f90e3b17faf0f/License.txt#L138-L140

The GPL license requires to access to all corresponding source to be free of charge.

https://github.com/electronicarts/CnC_Remastered_Collection/blob/d9e287e08b3e2fb3e46690d1029f90e3b17faf0f/License.txt#L270-L271

corresponding source would be the game launcher. The code that includes the main to generate the .exe file.

As far as I can tell now it means everybody can now request access to the source code of the game launcher.

You should have picked LGPL for this.

khm1600 commented 4 years ago

Except they hold the copyright of the code and licenses it differently (not GPL) when you buy the game (and receive it in object form).

And also:

https://github.com/electronicarts/CnC_Remastered_Collection/blob/d9e287e08b3e2fb3e46690d1029f90e3b17faf0f/License.txt#L155-L156

For mods based on this code, there's #5

annopnod commented 4 years ago

i think CnC Remastered Collection is open source. but sell game asset. exsimple game image,3d object,video,audio

annopnod commented 4 years ago

sell art(audio,picture) online. not sell game

krux02 commented 4 years ago

Except they hold the copyright of the code and licenses it differently (not GPL) when you buy the game (and receive it in object form).

That doesn't change the fact that this source code here is distributed under GPL. And the issue is reported on this GPL licensed version.

khm1600 commented 4 years ago

The "Corresponding Source" for a work in object code form means all the source code needed to generate, install, and (for an executable work) run the object code and to modify the work, including scripts to control those activities.

This source code here is in source code form and not in object code form,. Therefore, this part does not apply.

The definition for source code and object code in GPL:

The "source code" for a work means the preferred form of the work for making modifications to it. "Object code" means any non-source form of a work.

hifi commented 3 years ago

I'm going to return to this very old thread to point out that even though the original purpose of the source was modding for the Remastered collection it does work standalone without the proprietary GlyphX engine with enough work put into it.

Technically the work we've done in Vanilla Conquer might be enough to make some people happy as we have both games in playable state while we still support modding the Remaster with the same code base as well so it should be win-win.

krux02 commented 3 years ago

Hi, thank you for finding a solution to run the game without proprietary dependencies. I will later take a look into it and see if I can get it running.