search

electronicarts / EASTL

EASTL stands for Electronic Arts Standard Template Library. It is an extensive and robust implementation that has an emphasis on high performance.
BSD 3-Clause "New" or "Revised" License
7.82k stars 905 forks source link

Declare C++14 as required for building #509

Closed uilianries closed 12 months ago

uilianries commented 1 year ago

The EASTL uses C++11 and C++14 features like static_assert and constexpr, however, there is no assigned standard in CMakeLists.txt, which breaks older compiler like GCC 5. Plus, it provides an non predictable scenario, as may depend on the standard supported by the compiler.

It would be much safer by adding the minimal C++ standard required to build EASTL, so people can reproduce their scenario when building EASTL.

grojo-ea commented 1 year ago

Hello,

This looks good to me.

I noticed we don't have a CLA for you, would you mind filling out the form? Then we can merge this when the conflicts are resolved.

Thanks

uilianries commented 1 year ago

@grojo-ea It's done, the CLA is signed and conflicts are solved. Thank you.

grojo-ea commented 12 months ago

Thanks!