electronicarts / dem-bones

An automated algorithm to extract the linear blend skinning (LBS) from a set of example poses
https://seed.ea.com
Other
868 stars 154 forks source link

Could it be possible to transform joint scale? #10

Closed JonasOuellet closed 3 years ago

JonasOuellet commented 4 years ago

Hi and thanks a lot for this, it works very well !

I was wondering if it could be possible to allow joint scale to better match the deformed geometry. I think, in some cases where scale is supported, it could help reduce the number of bone needed.

Thanks again!

binhhuyle commented 3 years ago

Sorry for the very late reply. Currently, dem-bones does not solve scale because it is not very widely used.

But you can solve the scale in a similar way to: http://graphics.stanford.edu/~smr/ICP/comparison/horn-hilden-orientation-josa88.pdf

This solver can be injected to function void DemBones::qpT2m(const Matrix4& _qpT, int k, int j) which solves rotation in the current version.