electronicarts / ea-async

EA Async implements async-await methods in the JVM.
https://go.ea.com/ea-async
Other
1.38k stars 129 forks source link

Upgrade bytebuddy and ASM #41

Closed coder17934 closed 5 years ago

coder17934 commented 5 years ago

Version 1.2.2 causes the following running on Amazon Corretto 11. The main reason seems to be that ByteBuddy did not support Java 11 until version 1.9.0 (https://github.com/raphw/byte-buddy/blob/master/release-notes.md). As the current version of ByteBuddy is reliant of ASM 7.1 I upgraded that dependency as well.

#
# A fatal error has been detected by the Java Runtime Environment:
#
#  SIGSEGV (0xb) at pc=0x0000000107c5ca9b, pid=7729, tid=6659
#
# JRE version: OpenJDK Runtime Environment (11.0.3+7) (build 11.0.3+7-LTS)
# Java VM: OpenJDK 64-Bit Server VM (11.0.3+7-LTS, mixed mode, tiered, compressed oops, g1 gc, bsd-amd64)
# Problematic frame:
# V  [libjvm.dylib+0x65ca9b]  ResolvedMethodTable::add_method(Handle)+0x61
#
# No core dump will be written. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again
#
# If you would like to submit a bug report, please visit:
#   http://bugreport.java.com/bugreport/crash.jsp
#
JoeHegarty commented 5 years ago

Thanks for the contribution. I should be able to get this released during the week.

JoeHegarty commented 5 years ago

Released in v1.2.3

coder17934 commented 5 years ago

Great, thank you!