electronicarts / ea-async

EA Async implements async-await methods in the JVM.
https://go.ea.com/ea-async
Other
1.38k stars 129 forks source link

Method references `Async::await` are not taken away #45

Open azurvii opened 4 years ago

azurvii commented 4 years ago

The instrumentation tool takes away all Async.await occurrences, but does not take away Async::await. I think this is a bug?

E.g.

final List<CompletableFuture<Void>> futures = new ArrayList<>();
futures.add(CompletableFuture.completedFuture(null));
futures.stream().map(Async::await).collect(Collectors.toList());

The Async::await stays after instrumentation.

JoeHegarty commented 4 years ago

Yes, this is likely a bug. A PR would be welcome, unfortunately I am unlikely to get time to fix in the near future.