search

electronicarts / ea-async

EA Async implements async-await methods in the JVM.
https://go.ea.com/ea-async
Other
1.38k stars 129 forks source link

Java 14 Support? #52

Open gary-archer opened 4 years ago

gary-archer commented 4 years ago

Nice library guys - have been using it for a while - makes non blocking Rest API code much easier to write reliably.

Just wondered if it could be updated to support the latest Java, which I was trying to use? I believe the below issue is related to the version of ASM dependencies.

Not massively urgent, but nice to keep your library working with latest versions.

Caused by: java.lang.IllegalArgumentException: Unsupported class file major version 58 at com.ea.async.shaded.org.objectweb.asm.ClassReader.(ClassReader.java:195) at com.ea.async.shaded.org.objectweb.asm.ClassReader.(ClassReader.java:176) at com.ea.async.shaded.org.objectweb.asm.ClassReader.(ClassReader.java:162) at com.ea.async.instrumentation.Transformer.transform(Transformer.java:150)

Mart-Bogdan commented 3 years ago

Looks like it could be tended with this PR https://github.com/electronicarts/ea-async/pull/51