search

electronoora / webaudio-mod-player

MOD/S3M/XM module player for Web Audio
https://mod.haxor.fi/
MIT License
364 stars 54 forks source link

General cleanup #8

Closed jhnsnc closed 8 years ago

jhnsnc commented 8 years ago

I've been wanting to to better understand the implementation details of this repo and maybe make some improvements or experiment with related ideas. For example, I would love to clearly separate the modplayer code from the UI code (as mentioned in #5 ) and use that to experiment with a simple web synth/keyboard.

As I read through the code, I've been noticing some small style inconsistencies. Would it be okay with you if I did a general style cleanup on the repo?

Here are some simple changes I'm thinking of for a first pass:

Here are some other ideas for a second pass:

I haven't done any of this yet--I wanted to ask first to make sure I'm not offending you or anything. I know this is a personal project of yours so I would hate for you to think I'm meddling. It's definitely a cool project and I hope I can find more time to work on it! :smile:

jhnsnc commented 8 years ago

We may still want to do another cleanup pass, but I'm going to close this since the PR got merged.

Future PRs from me may include additional commenting and minor cleanup, but I'll hold on any major cleanup unless someone else brings it up as an issue. We might also want to consider adopting a particular style guide for the JS, but at least for now I'll follow the existing style.