Closed pkulev closed 2 years ago
The GitHub Actions builds seem to be failing.
The windows failure is my fault, it was failing before. The Mac failure is caused by the PR I think. Will look at it when I have time.
I temporarily disabled the change and macos still failing. I think it's because of MACOSX_DEPLOYMENT_TARGET: 10.14
. The runner's version is 10.15.
So probably something changed in GHA recently.
Also maybe it's time to add macos 12 build too, maybe without artifacts, because on 12.3 Intel chip build fails like in linked issue.
i added a macos12 build, and it works on Github Actions, even though I haven't added your patch yet!
Seems Github Actions no longer supports 10.14. I can build on 10.15 but even that wont accept 10.14 deployment target.
It looks like the code in your patch is commented out, I guess you want to add: include_dirs=[get_the_include_path()],
?
I commented it just to check whether my change failing build.
ok change is done, and it's all building (except not for macos 10.14)
Ah, you did the change yourself. You should have waited for me to rebase =(
Probably something changed in MacOS since 10.14 with default include directories and clang.
This change was tested on MacOS 12 with both M1 and intel chips.
CFFI documentation says:
I think it's also safe to pass raylib header directory on other platforms too.
Closes: #63