Closed tthornton3-chwy closed 1 year ago
Great! Thanks for picking it up and glad to hear my small contribution was useful :)
Hey thanks for this @tthornton3-chwy! I'll try to take a look this weekend.
@richardsimko note that I added an empty commit to the main
branch under your name to indicate your contribution of the concat
doc fix patch from #27 (in this comment https://github.com/electrovir/prettier-plugin-multiline-arrays/pull/27#discussion_r1319867801):
(The commit is empty because the changes were already incorporated into @tthornton3-chwy's commit fded62c
but I didn't want to rebase this branch as it would nuke the "verified" status of their commits.)
Thanks again @electrovir for your amazing work on this plugin-- this is a huge thing for a lot of people that you've managed to help! Cheers!
This is a fork off of https://github.com/electrovir/prettier-plugin-multiline-arrays/pull/27, that applies the diff provided by @richardsimko (thank you!), then fixes the tests / formatting etc.
This took a bit of debugging!
Worth noting-- I monkey patched
prettier-plugin-organize-imports
, because otherwise I would have had to re-write a bunch of javascript tests. I did it in an "okay" way, but we should probably no longer assume type declarations are allowed in plain js! Or maybe we could try adding the@flow
annotation?? I tried for 2 seconds and it didn't immediately work, so I just did this haha.